Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, the limitador image being used in the deployment is read from different sources with some order of precedence:
spec.version
is set -> image =quay.io/kuadrant/limitador:${spec.version}
(note the repo is hardcoded)RELATED_IMAGE_LIMITADOR
env var is set -> image =$RELATED_IMAGE_LIMITADOR
quay.io/kuadrant/limitador:latest
This PR introduces a new CRD field,
spec.image
that deprecatesspec.version
where you can set the full docker image URL. Allowing using custom docker image repos. Using private repos is not supported yet, we need to implement the pullSecret, another field where you can specify credentials to access private repos.The
spec.image
field is not meant to be used in production environments. It is meant to be used for dev/testing purposes. The main drawback of thespec.image
usage is that upgrades cannot be supported as the limitador operator cannot ensure the operation to be safe.New order of precedence:
spec.image
is set -> image =${spec.image}
spec.version
is set -> image =quay.io/kuadrant/limitador:${spec.version}
(note the repo is hardcoded)RELATED_IMAGE_LIMITADOR
env var is set -> image =$RELATED_IMAGE_LIMITADOR
quay.io/kuadrant/limitador:latest
Verification Steps
dev setup
Deploy the limitador CR with custom image URL (not from
quay.io/kuadrant/limitador
)Check deployment is correct
Should return
Check command line
should look like this